You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Mingshen Sun <no...@github.com.INVALID> on 2021/12/14 03:10:27 UTC

[apache/incubator-teaclave] Fix rebuild packages every time (PR #589)

## Description

This PR fix building issue.

According to https://github.com/rust-lang/cargo/issues/2904, I enabled cargo log with `CARGO_LOG=cargo::core::compiler::fingerprint=trace` and see this log:

```
[2021-12-14T02:19:39Z INFO  cargo::core::compiler::fingerprint]     err: RUSTFLAGS has changed: [&quot;--cfg&quot;, &quot;test_mode&quot;, &quot;--cfg&quot;, &quot;sgx_sim&quot;, &quot;--cfg&quot;, &quot;executor_builtin&quot;, &quot;--cfg&quot;, &quot;executor_mesapy&quot;, &quot;--cfg&quot;, &quot;executor_wamr&quot;, &quot;--cfg&quot;, &quot;test_mode&quot;] != [&quot;--cfg&quot;, &quot;test_mode&quot;, &quot;--cfg&quot;, &quot;sgx_sim&quot;, &quot;--cfg&quot;, &quot;executor_builtin&quot;, &quot;--cfg&quot;, &quot;executor_mesapy&quot;, &quot;--cfg&quot;, &quot;executor_wamr&quot;]
```

I realize that this additional `test_mode` flag affect the rebuild. However, when building with `TEST_MODE=ON`, the `test_mode` flag has been added to all services. Therefore, we can safely delete this.


## Type of change (select or add applied and delete the others)

- [x] Bug fix (non-breaking change which fixes an issue)

## How has this been tested?

CI.

## Checklist

- [x] Fork the repo and create your branch from `master`.
- [x] If you&#39;ve added code that should be tested, add tests.
- [x] If you&#39;ve changed APIs, update the documentation.
- [x] Ensure the tests pass (see CI results).
- [x] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/589

-- Commit Summary --

  * Fix rebuild packages every time

-- File Changes --

    M cmake/TeaclaveUtils.cmake (4)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/589.patch
https://github.com/apache/incubator-teaclave/pull/589.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/589

Re: [apache/incubator-teaclave] Fix packages rebuild every time (PR #589)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Merged #589 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/589#event-5766277707