You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/08/23 23:58:16 UTC
[GitHub] [trafficserver] scw00 opened a new issue #5505: dir_token is useless anymore is should be removed
scw00 opened a new issue #5505:
URL: https://github.com/apache/trafficserver/issues/5505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on issue #5505: dir_token is useless anymore is should be removed
Posted by GitBox <gi...@apache.org>.
masaori335 commented on issue #5505:
URL: https://github.com/apache/trafficserver/issues/5505#issuecomment-918701089
FWIW, the `dir_set_token()` calls were dead code and removed by this commit.
https://github.com/apache/trafficserver/commit/6f155f44466c91aa892b861777c914b1ddde7b99#diff-b194c2cc95f7657ac89659cbad6b6d3b3dd80ff4ad5757ff1bbe4b0ac482b983L240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall closed issue #5505: dir_token is useless anymore is should be removed
Posted by GitBox <gi...@apache.org>.
bryancall closed issue #5505:
URL: https://github.com/apache/trafficserver/issues/5505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode closed issue #5505: dir_token is useless anymore is should be removed
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode closed issue #5505:
URL: https://github.com/apache/trafficserver/issues/5505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on issue #5505: dir_token is useless anymore is should be removed
Posted by GitBox <gi...@apache.org>.
bryancall commented on issue #5505:
URL: https://github.com/apache/trafficserver/issues/5505#issuecomment-904203517
This is used in:
` iocore/cache/CacheDir.cc: if (!dir_token(e) && dir_offset(e) >= static_cast<int64_t>(start) && dir_offset(e) < static_cast<int64_t>(end)) {`
Please reopen if this still needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on issue #5505: dir_token is useless anymore is should be removed
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on issue #5505:
URL: https://github.com/apache/trafficserver/issues/5505#issuecomment-904214050
That reads it, but I can't find any place it would be set. There is `dir_set_token` but it's never called. I think @scw00 is correct, those bits are never set, and therefore are not useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org