You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/02/17 10:43:41 UTC

[GitHub] [jackrabbit-oak] stefan-egli commented on a change in pull request #276: OAK-9358: DocumentNodeStore may accumulate split candidates

stefan-egli commented on a change in pull request #276:
URL: https://github.com/apache/jackrabbit-oak/pull/276#discussion_r577506368



##########
File path: oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java
##########
@@ -2527,8 +2527,8 @@ private void backgroundSplit() {
             invalidatePaths(pathsToInvalidate);
             batchSplit(splitOpsPhase1);
             batchSplit(splitOpsPhase2);
-            splitCandidates.keySet().removeAll(removeCandidates);
         }
+        splitCandidates.keySet().removeAll(removeCandidates);

Review comment:
       This fixes indeed a regression, nice catch! (The above change fixes an older bug, that was there before)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org