You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2015/02/23 09:57:32 UTC
Review Request 31296: CLOUDSTACK-8277: Code improvement -
test_multiple_ip_ranges.py, test_shared_networks.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31296/
-----------------------------------------------------------
Review request for cloudstack and sanjeev n.
Bugs: CLOUDSTACK-8277
https://issues.apache.org/jira/browse/CLOUDSTACK-8277
Repository: cloudstack-git
Description
-------
The test suites require following code improvements.
1. Remove import *, and replace with specific imports
2. Fix pep8 issues.
3. Remove unnecessary try catch blocks
4. Print detailed exception message whenever missing
Above changes included in the patch.
Diffs
-----
test/integration/component/test_multiple_ips_per_nic.py 58aac9f
test/integration/component/test_shared_networks.py 4d71ed3
Diff: https://reviews.apache.org/r/31296/diff/
Testing
-------
Yes.
Add secondary IP to NIC of a VM ... === TestName: test_add_ip_to_nic_1_SHARED | Status : SUCCESS ===
ok
Test listing nics associated with the ip address ... === TestName: test_list_nics_1_SHARED | Status : SUCCESS ===
ok
Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_1_SHARED |
Status : SUCCESS ===
ok
Remove invalid ip ... === TestName: test_remove_invalid_ip | Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED |
Status : SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status :
SUCCESS ===
ok
Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status :
SUCCESS ===
ok
Test Shared Network ALL ...
----------------------------------------------------------------------
Ran 1 test in 570.117s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 31296: CLOUDSTACK-8277: Code improvement -
test_multiple_ip_ranges.py, test_shared_networks.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31296/#review74235
-----------------------------------------------------------
Ship it!
f39319932576804eaafb9e51235290fdf23f3841 master
- SrikanteswaraRao Talluri
On Feb. 23, 2015, 8:57 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31296/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 8:57 a.m.)
>
>
> Review request for cloudstack and sanjeev n.
>
>
> Bugs: CLOUDSTACK-8277
> https://issues.apache.org/jira/browse/CLOUDSTACK-8277
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test suites require following code improvements.
>
> 1. Remove import *, and replace with specific imports
> 2. Fix pep8 issues.
> 3. Remove unnecessary try catch blocks
> 4. Print detailed exception message whenever missing
>
>
> Above changes included in the patch.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ips_per_nic.py 58aac9f
> test/integration/component/test_shared_networks.py 4d71ed3
>
> Diff: https://reviews.apache.org/r/31296/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Add secondary IP to NIC of a VM ... === TestName: test_add_ip_to_nic_1_SHARED | Status : SUCCESS ===
> ok
> Test listing nics associated with the ip address ... === TestName: test_list_nics_1_SHARED | Status : SUCCESS ===
> ok
> Test basic operations using non root admin apii client ... === TestName: test_operations_non_root_admin_api_client_1_SHARED |
> Status : SUCCESS ===
> ok
> Remove invalid ip ... === TestName: test_remove_invalid_ip | Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED |
> Status : SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status :
> SUCCESS ===
> ok
> Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status :
> SUCCESS ===
> ok
>
> Test Shared Network ALL ...
> ----------------------------------------------------------------------
> Ran 1 test in 570.117s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>