You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/10 21:39:11 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3084: Make RowSelection::intersection a member function

tustvold commented on code in PR #3084:
URL: https://github.com/apache/arrow-rs/pull/3084#discussion_r1019636168


##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -349,19 +361,19 @@ impl From<RowSelection> for VecDeque<RowSelector> {
     }
 }
 
-// Combine two lists of `RowSelection` return the intersection of them
-// For example:
-// self:      NNYYYYNNYYNYN
-// other:     NYNNNNNNY
-//
-// returned:  NNNNNNNNYYNYN
-pub fn intersect_row_selections(

Review Comment:
   We could also keep this public, but I don't see a reason to do so



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org