[jira] Commented: (WICKET-348) Propose removing 'final' modifier to AbstractSingleSelectChoice.convertValue()

["Johan Compagner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505725 ] 

Johan Compagner commented on WICKET-348:
----------------------------------------

then the interface would be come much more poluted and harder to implement.

Also what about ListMultipleChoice.convertValue() ?
that works a little bit different. you can't have the convertChoiceIdToChoice but convertChoicesIdToChoices?

i think the current way is fine (except maybe also refactor the ListMultiplyChoice.convertValue)

> Propose removing 'final' modifier to AbstractSingleSelectChoice.convertValue()
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-348
>                 URL: https://issues.apache.org/jira/browse/WICKET-348
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 2.0 branch (discontinued)
>            Reporter: Brian Topping
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.0-beta2
>
>
> While creating a subclass of DropDownChoice, I wanted to write a specialized reverse mapping function that would allow the option value to be used as the primary key for direct lookup of the object.  Unfortunately, AbstractSingleSelectChoice.convertValue() is has a 'final' modifier.  (I'm guessing this is an inside joke because it does a linear search... ;-))
> Any chance of removing the final modifier?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.