You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Ashwini Adiga <as...@gmail.com> on 2019/03/01 01:06:05 UTC
merging of airflow pull request
Hi Devs,
I would like to get some procedure to merge the pull request:
https://github.com/apache/airflow/pull/4583,
it prevent missing container exit for docker operator with celery. The
pull request passes all the tests and it was reviewed by one developer.
If someone help to get the procedure to merge the pull request or
feedback on the pull request will be off great help.
Thanks in advance for your help.
--
Regards,
Ashwini
ashwini.adigam@gmail.com
答复: merging of airflow pull request
Posted by zhong jiajie <zh...@hotmail.com>.
I review your PR, And AT some committer/PMC to review you PR
________________________________
发件人: Ashwini Adiga <as...@gmail.com>
发送时间: 2019年3月1日 9:06
收件人: dev@airflow.apache.org
抄送: Ravi.Terala@nordstrom.com
主题: merging of airflow pull request
Hi Devs,
I would like to get some procedure to merge the pull request:
https://github.com/apache/airflow/pull/4583,
it prevent missing container exit for docker operator with celery. The
pull request passes all the tests and it was reviewed by one developer.
If someone help to get the procedure to merge the pull request or
feedback on the pull request will be off great help.
Thanks in advance for your help.
--
Regards,
Ashwini
ashwini.adigam@gmail.com
Re: merging of airflow pull request
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
Sorry for the late reply Ashwini. Could you rebase the PR onto master?
There are issues with Python2.
Cheers, Fokko
Op di 30 apr. 2019 om 22:09 schreef Daniel Imberman <
dimberman.opensource@gmail.com>:
> I'm rerunning it now to see if the failing test will pass. If it does I'll
> merge it.
>
> On Tue, Apr 30, 2019 at 12:31 PM Ashwini Adiga <as...@gmail.com>
> wrote:
>
> > Hi Devs,
> >
> > I would like to know the update on this pull request.
> > https://github.com/apache/airflow/pull/4583,
> > This has been approved by ashb on Mar24 but still not merged. Can you
> > please help this merge the pull request it is very helpful.
> > Thanks in advance for your help.
> >
> > Ashwini
> >
> > On Thu, Feb 28, 2019 at 5:06 PM Ashwini Adiga <as...@gmail.com>
> > wrote:
> >
> > > Hi Devs,
> > >
> > > I would like to get some procedure to merge the pull request:
> > > https://github.com/apache/airflow/pull/4583,
> > > it prevent missing container exit for docker operator with celery. The
> > > pull request passes all the tests and it was reviewed by one
> developer.
> > >
> > > If someone help to get the procedure to merge the pull request or
> > feedback on the pull request will be off great help.
> > > Thanks in advance for your help.
> > >
> > >
> > > --
> > > Regards,
> > > Ashwini
> > >
> > > ashwini.adigam@gmail.com
> > >
> >
> >
> > --
> > Regards,
> > Ashwini
> > 440-804-6339
> > ashwini.adigam@gmail.com
> >
>
Re: merging of airflow pull request
Posted by Daniel Imberman <di...@gmail.com>.
I'm rerunning it now to see if the failing test will pass. If it does I'll
merge it.
On Tue, Apr 30, 2019 at 12:31 PM Ashwini Adiga <as...@gmail.com>
wrote:
> Hi Devs,
>
> I would like to know the update on this pull request.
> https://github.com/apache/airflow/pull/4583,
> This has been approved by ashb on Mar24 but still not merged. Can you
> please help this merge the pull request it is very helpful.
> Thanks in advance for your help.
>
> Ashwini
>
> On Thu, Feb 28, 2019 at 5:06 PM Ashwini Adiga <as...@gmail.com>
> wrote:
>
> > Hi Devs,
> >
> > I would like to get some procedure to merge the pull request:
> > https://github.com/apache/airflow/pull/4583,
> > it prevent missing container exit for docker operator with celery. The
> > pull request passes all the tests and it was reviewed by one developer.
> >
> > If someone help to get the procedure to merge the pull request or
> feedback on the pull request will be off great help.
> > Thanks in advance for your help.
> >
> >
> > --
> > Regards,
> > Ashwini
> >
> > ashwini.adigam@gmail.com
> >
>
>
> --
> Regards,
> Ashwini
> 440-804-6339
> ashwini.adigam@gmail.com
>
Re: merging of airflow pull request
Posted by Ashwini Adiga <as...@gmail.com>.
Hi Devs,
I would like to know the update on this pull request.
https://github.com/apache/airflow/pull/4583,
This has been approved by ashb on Mar24 but still not merged. Can you
please help this merge the pull request it is very helpful.
Thanks in advance for your help.
Ashwini
On Thu, Feb 28, 2019 at 5:06 PM Ashwini Adiga <as...@gmail.com>
wrote:
> Hi Devs,
>
> I would like to get some procedure to merge the pull request:
> https://github.com/apache/airflow/pull/4583,
> it prevent missing container exit for docker operator with celery. The
> pull request passes all the tests and it was reviewed by one developer.
>
> If someone help to get the procedure to merge the pull request or feedback on the pull request will be off great help.
> Thanks in advance for your help.
>
>
> --
> Regards,
> Ashwini
>
> ashwini.adigam@gmail.com
>
--
Regards,
Ashwini
440-804-6339
ashwini.adigam@gmail.com