You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2023/01/12 01:28:05 UTC

[doris] branch master updated: [log](vlog) improve vlog print for query TExecPlanFragmentParams (#15806)

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 791604ba1f [log](vlog) improve vlog print for query TExecPlanFragmentParams (#15806)
791604ba1f is described below

commit 791604ba1f7e3bf39cd79b30758f2a966eb319d3
Author: TengJianPing <18...@users.noreply.github.com>
AuthorDate: Thu Jan 12 09:27:59 2023 +0800

    [log](vlog) improve vlog print for query TExecPlanFragmentParams (#15806)
    
    * [log] improve vlog print for query TExecPlanFragmentParams
    
    * improvement
---
 be/src/runtime/fragment_mgr.cpp    | 6 ++++++
 be/src/service/backend_service.cpp | 2 --
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/be/src/runtime/fragment_mgr.cpp b/be/src/runtime/fragment_mgr.cpp
index 2d89b2e8a1..ac3b9ff0e6 100644
--- a/be/src/runtime/fragment_mgr.cpp
+++ b/be/src/runtime/fragment_mgr.cpp
@@ -611,6 +611,12 @@ void FragmentMgr::remove_pipeline_context(
 Status FragmentMgr::exec_plan_fragment(const TExecPlanFragmentParams& params, FinishCallback cb) {
     auto tracer = telemetry::is_current_span_valid() ? telemetry::get_tracer("tracer")
                                                      : telemetry::get_noop_tracer();
+    VLOG_ROW << "exec_plan_fragment params is "
+             << apache::thrift::ThriftDebugString(params).c_str();
+    // sometimes TExecPlanFragmentParams debug string is too long and glog
+    // will truncate the log line, so print query options seperately for debuggin purpose
+    VLOG_ROW << "query options is "
+             << apache::thrift::ThriftDebugString(params.query_options).c_str();
     START_AND_SCOPE_SPAN(tracer, span, "FragmentMgr::exec_plan_fragment");
     const TUniqueId& fragment_instance_id = params.params.fragment_instance_id;
     {
diff --git a/be/src/service/backend_service.cpp b/be/src/service/backend_service.cpp
index 0853aa1fa7..d61cc040d3 100644
--- a/be/src/service/backend_service.cpp
+++ b/be/src/service/backend_service.cpp
@@ -87,8 +87,6 @@ void BackendService::exec_plan_fragment(TExecPlanFragmentResult& return_val,
                                         const TExecPlanFragmentParams& params) {
     LOG(INFO) << "exec_plan_fragment() instance_id=" << params.params.fragment_instance_id
               << " coord=" << params.coord << " backend#=" << params.backend_num;
-    VLOG_ROW << "exec_plan_fragment params is "
-             << apache::thrift::ThriftDebugString(params).c_str();
     start_plan_fragment_execution(params).set_t_status(&return_val);
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org