You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/04 03:07:03 UTC

[GitHub] [beam] ihji commented on a change in pull request #13606: [BEAM-11519] Adding PYPI_INSTALL_REQ role and SDK container support

ihji commented on a change in pull request #13606:
URL: https://github.com/apache/beam/pull/13606#discussion_r569914076



##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1342,7 +1342,11 @@ message StandardArtifacts {
   enum Roles {
     // A URN for staging-to role.
     // payload: ArtifactStagingToRolePayload
-    STAGING_TO  = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+    STAGING_TO        = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+
+    // A URN for pypi-install-requirement role.
+    // payload: None
+    PYPI_INSTALL_REQUIREMENT  = 1 [(beam_urn) = "beam:artifact:role:pypi_install_requirement:v1"];

Review comment:
       Use PIP_REQUIREMENTS_FILE instead of PYPI_INSTALL_REQUIREMENT




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org