[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4747: Centralize settings in the build process to avoid duplication.

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4747: Centralize settings in the build process to avoid duplication.
URL: https://github.com/apache/openwhisk/pull/4747#discussion_r349536596
 
 

 ##########
 File path: core/standalone/build.gradle
 ##########
 @@ -16,20 +16,15 @@
  */
 
 plugins {
+    id 'maven'
+    id 'org.scoverage'
     id 'org.springframework.boot' version '2.1.6.RELEASE'
-    id "com.gorylenko.gradle-git-properties" version "2.0.0"
     id 'scala'
+    id 'com.gorylenko.gradle-git-properties' version '2.0.0'
 
 Review comment:
   While we are at this lets move all plugin versions to `settings.gradle` such that all versions are at one place. See https://docs.gradle.org/current/userguide/plugins.html#sec:plugin_version_management for details.
   
   Something like below in `settings.gradle`
   
   ```gradle
   pluginManagement {
       plugins {
           id 'cz.alenkacz.gradle.scalafmt' version '1.8.0'
           id 'org.scoverage' version '3.2.0'
           id 'com.gorylenko.gradle-git-properties' version '2.2.0'
           id 'org.springframework.boot' version '2.2.1.RELEASE'
       }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services