[GitHub] [maven] elharo commented on a change in pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

[GitBox <gi...@apache.org>]

elharo commented on a change in pull request #429:
URL: https://github.com/apache/maven/pull/429#discussion_r567254403



##########
File path: maven-core/src/main/java/org/apache/maven/DefaultMaven.java
##########
@@ -493,22 +505,88 @@ private void validatePrerequisitesForNonMavenPluginProjects( List<MavenProject>
         }
     }
 
-    private void validateActivatedProfiles( List<MavenProject> projects, List<String> activeProfileIds )
+    /**
+     * Get all profiles that are detected in either the projects, any parent of the projects or the settings.

Review comment:
       I don't think you want to switch this to a negative, unless that's what the method does? I don't know. I think what's needed here is
   
   "Get all profiles that are detected in the projects, any parent of the projects, or the settings."
   
   unless that's exactly backwards, in which case it can be
   
   "Get all profiles that are not detected in the projects, any parent of the projects, or the settings."
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org