[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1244: ORC-1266: DecimalColumnVector resets the isRepeating flag in the nextVector method

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #1244:
URL: https://github.com/apache/orc/pull/1244#discussion_r972706028


##########
java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java:
##########
@@ -1708,6 +1724,32 @@ private void nextVector(Decimal64ColumnVector result,
       result.scale = (short) scale;
     }
 
+    private void setIsRepeatingIfNeeded(Decimal64ColumnVector result, int index) {
+      if (result.isRepeating
+          && index > 0
+          && (result.vector[0] != result.vector[index] ||
+          result.isNull[0] != result.isNull[index])) {

Review Comment:
   Indentation on line 1731 looks wrong to me. Did you want the following?
   ```java
   && (result.vector[0] != result.vector[index] || result.isNull[0] != result.isNull[index])) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org