[jira] Commented: (OPENJPA-477) making StoreManager more flexible and extensible.

["Pinaki Poddar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556266#action_12556266 ] 

Pinaki Poddar commented on OPENJPA-477:
---------------------------------------

Agree that StoreManager should relax its field/method access for easier extensibility as well as to reuse rich implementations of JDBCStoreManager. However, this relaxation should be taken place in a more on-demand basis driven by use cases. This observation is based on my recent experience in extending JDBCStoreManager 
       a) to transact on distributed databases as opposed to a single database 
and b) adapt for XA-complaint data sources. 
Both extensions required access relaxations of one private field and one method signatures. But the changes were localized, driven by specific use cases. Hence, I recommend that we change fields/methods from private to protected as and when a particular use case demands it rather than doing it across the board as this patch seems to suggest. 

> making StoreManager more flexible and extensible.
> -------------------------------------------------
>
>                 Key: OPENJPA-477
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-477
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: kernel
>    Affects Versions: 1.0.2
>            Reporter: Daniel Lee
>             Fix For: 1.0.2, 1.1.0
>
>         Attachments: OPENJPA-477.patch
>
>
> The OpenJPA StoreManager needs some modifications to make it more flexible and extensible.  For example, some private methods and attributes need to made either public or protected.  The attached patch identifies the areas that have been identified thus far.  Please let me know if there are any concerns.  Many thanks in advance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.