[jira] [Commented] (TS-3917) Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame

["Masakazu Kitajo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065453#comment-15065453 ] 

Masakazu Kitajo commented on TS-3917:
-------------------------------------

It seems that the current implementation does send the differences but the value to compare embedded in HTTP2.h differs from the one defined on the specification.
https://github.com/apache/trafficserver/blob/6.0.x/proxy/http2/HTTP2.h#L58

So the actual issue is that the initial value for SETTINGS_MAX_CONCURRENT_STREAMS differs from the specification.

Though I don't know why the value differs, it can be fixed by just changing the value above to UINT_MAX.

> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> -----------------------------------------------------------
>
>                 Key: TS-3917
>                 URL: https://issues.apache.org/jira/browse/TS-3917
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Masaori Koshiba
>            Assignee: Bryan Call
>            Priority: Critical
>             Fix For: 6.1.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but default value in records.config is 100. ATS should send this value in first SETTINGS Frame but not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)