You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sg...@apache.org on 2015/03/06 12:16:27 UTC

spec commit: CB-8620 Made wp8 tests not to run on windows

Repository: cordova-mobile-spec
Updated Branches:
  refs/heads/master aa9b4ff90 -> b911ce1e9


CB-8620 Made wp8 tests not to run on windows

github close #120


Project: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/commit/b911ce1e
Tree: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/tree/b911ce1e
Diff: http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/diff/b911ce1e

Branch: refs/heads/master
Commit: b911ce1e951a2d74947dab3f99f92621ea769138
Parents: aa9b4ff
Author: alsorokin <al...@akvelon.com>
Authored: Fri Mar 6 13:24:56 2015 +0300
Committer: sgrebnov <v-...@microsoft.com>
Committed: Fri Mar 6 14:16:13 2015 +0300

----------------------------------------------------------------------
 cordova-plugin-mobilespec-tests/tests/localXHR.tests.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-mobile-spec/blob/b911ce1e/cordova-plugin-mobilespec-tests/tests/localXHR.tests.js
----------------------------------------------------------------------
diff --git a/cordova-plugin-mobilespec-tests/tests/localXHR.tests.js b/cordova-plugin-mobilespec-tests/tests/localXHR.tests.js
index d579ea0..835a3d7 100644
--- a/cordova-plugin-mobilespec-tests/tests/localXHR.tests.js
+++ b/cordova-plugin-mobilespec-tests/tests/localXHR.tests.js
@@ -20,6 +20,8 @@
  */
 
 exports.defineAutoTests = function () {
+    var isWp8 = cordova.platformId === "windowsphone";
+
     describe("XMLHttpRequest", function () {
         var errorHandler = {
             onError: function (done) {
@@ -171,7 +173,7 @@ exports.defineAutoTests = function () {
 
     // only add these tests if we are testing on windows phone
 
-    if (/Windows Phone/.exec(navigator.userAgent)) {
+    if (isWp8) {
         describe("XMLHttpRequest Windows Phone", function () {
 
             var errorHandler = { onError: function () { } };
@@ -193,7 +195,6 @@ exports.defineAutoTests = function () {
                 return xhr;
             };
 
-            console.log("running special windows tests");
             it("XMLHttpRequest.spec.7 should be able to load the (WP8 backwards compatability) root page www/index.html", function (done) {
                 expect(function () {
                     createXHR("www/index.html", true, done, errorHandler.onError)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org