[GitHub] reddycharan edited a comment on issue #1532: (WIP) ISSUE #1527: Make ExplicitLAC persistent

[GitBox <gi...@apache.org>]

reddycharan edited a comment on issue #1532: (WIP) ISSUE #1527: Make ExplicitLAC persistent
URL: https://github.com/apache/bookkeeper/pull/1532#issuecomment-401876404
 
 
   @eolivelli Thanks for going through WIProgress CR. I would like to get feedback on the approach. Yes I need to add tests and I'm working on it.
   
   Regarding fenced/setexplicitlac concern you raised, if I understood you correctly you are suggesting that we should have similar check like https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java#L1235
   
   But I don't think that this check is needed for set explicitLac call, because ExplicitLacFlush is periodic delayed operation - https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ExplicitLacFlushPolicy.java#L82 so by the time write handle pushes set explicitLac request (or set explicitLac requests might be in flight), ledger might have been recover opened (fenced), but it is legally ok for bookie to receive setExplicitLac call and set explicitLac accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services