You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by "likyh (via GitHub)" <gi...@apache.org> on 2023/03/17 01:49:55 UTC

[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4696: fix(config-ui): missed timeAfter after change data scope

likyh commented on code in PR #4696:
URL: https://github.com/apache/incubator-devlake/pull/4696#discussion_r1139552933


##########
config-ui/src/pages/blueprint/detail/panel/configuration.tsx:
##########
@@ -96,7 +96,7 @@ export const Configuration = ({ blueprint, operating, onUpdate, onRefresh }: Pro
   const handleUpdateConnection = (updated: any) =>
     onUpdate({
       settings: {
-        version: '2.0.0',
+        ...blueprint.settings,

Review Comment:
   If the empty time filter hasn't been pass to the backend, I think we should fix this issue in backend. 😂



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org