You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by yl...@apache.org on 2016/08/12 14:04:51 UTC

svn commit: r1756187 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Author: ylavic
Date: Fri Aug 12 14:04:51 2016
New Revision: 1756187

URL: http://svn.apache.org/viewvc?rev=1756187&view=rev
Log:
mod_proxy_fcgi: forcing proxy_conn->close here is useless, same is done
either above in ap_proxy_determine_connection(), or below in
ap_proxy_release_connection().


Modified:
    httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c?rev=1756187&r1=1756186&r2=1756187&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c Fri Aug 12 14:04:51 2016
@@ -938,16 +938,6 @@ static int proxy_fcgi_handler(request_re
         goto cleanup;
     }
 
-    /* This scheme handler does not reuse connections by default, to
-     * avoid tying up a fastcgi that isn't expecting to work on 
-     * parallel requests.  But if the user went out of their way to
-     * type the default value of disablereuse=off, we'll allow it.
-     */  
-    backend->close = 1;
-    if (worker->s->disablereuse_set && !worker->s->disablereuse) { 
-        backend->close = 0;
-    }
-
     /* Step Two: Make the Connection */
     if (ap_proxy_check_connection(FCGI_SCHEME, backend, r->server, 0,
                                   PROXY_CHECK_CONN_EMPTY)



Re: svn commit: r1756187 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Posted by Yann Ylavic <yl...@gmail.com>.
On Wed, Aug 17, 2016 at 4:29 PM, Ruediger Pluem <rp...@apache.org> wrote:
>
>
> On 08/12/2016 04:04 PM, ylavic@apache.org wrote:
>> Author: ylavic
>> Date: Fri Aug 12 14:04:51 2016
>> New Revision: 1756187
>>
>> URL: http://svn.apache.org/viewvc?rev=1756187&view=rev
>> Log:
>> mod_proxy_fcgi: forcing proxy_conn->close here is useless, same is done
>> either above in ap_proxy_determine_connection(), or below in
>> ap_proxy_release_connection().
>>
>
> I don't think so. The default is disablereuse=off and the code you removed makes the
> default disablereuse=on

Indeed, I missed the default...
Reverted in r1757097, thanks!

Regards,
Yann.

Re: svn commit: r1756187 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

Posted by Ruediger Pluem <rp...@apache.org>.

On 08/12/2016 04:04 PM, ylavic@apache.org wrote:
> Author: ylavic
> Date: Fri Aug 12 14:04:51 2016
> New Revision: 1756187
> 
> URL: http://svn.apache.org/viewvc?rev=1756187&view=rev
> Log:
> mod_proxy_fcgi: forcing proxy_conn->close here is useless, same is done
> either above in ap_proxy_determine_connection(), or below in
> ap_proxy_release_connection().
> 

I don't think so. The default is disablereuse=off and the code you removed makes the
default disablereuse=on

Regards

R�diger