You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/11/27 14:56:11 UTC

[GitHub] incubator-brooklyn pull request: Interface to be used by CAMP, TOS...

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/366

    Interface to be used by CAMP, TOSCA, etc. application description implementors

    * The implementors will register themselves with brooklyn.
    * To instantiate an app from an unknown spec type all registered providers will be tried until success.
    
    Implementations for CAMP & TOSCA to come as separate PRs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn spec-creator-api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #366
    
----
commit 3412bf50d3d99bb495694036c6052868b4db0b34
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-11-27T13:52:05Z

    Interface to be used by implementors of application description specs to feed into Brooklyn

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Interface to be used by CAMP, TOS...

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/366#issuecomment-69004016
  
    Implemented in https://github.com/apache/incubator-brooklyn/pull/436 with modifications to suit the code requirements.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Interface to be used by CAMP, TOS...

Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/366#issuecomment-67480630
  
    lgtm, I suspect the builder failure is related to something else 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Interface to be used by CAMP, TOS...

Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/366#discussion_r22039327
  
    --- Diff: core/src/main/java/brooklyn/basic/internal/SpecCreator.java ---
    @@ -0,0 +1,14 @@
    +package brooklyn.basic.internal;
    +
    +import brooklyn.catalog.internal.CatalogItemDtoAbstract;
    +import brooklyn.entity.proxying.EntitySpec;
    +import brooklyn.management.ManagementContext;
    +import brooklyn.management.classloading.BrooklynClassLoadingContext;
    +import brooklyn.policy.PolicySpec;
    +
    +public interface SpecCreator {
    --- End diff --
    
    shall we annotate that as @Beta ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Interface to be used by CAMP, TOS...

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/366#issuecomment-68727768
  
    @neykov Anything more to add to this? Are there any implementations?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Interface to be used by CAMP, TOS...

Posted by neykov <gi...@git.apache.org>.
Github user neykov closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/366


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---