You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/27 09:09:46 UTC
[GitHub] [arrow] kou commented on a diff in pull request #14390: ARROW-18016: [CI] Add sccache to more jobs
kou commented on code in PR #14390:
URL: https://github.com/apache/arrow/pull/14390#discussion_r1006603159
##########
dev/tasks/macros.jinja:
##########
@@ -383,3 +383,16 @@ on:
{{ key }}: "{{ value }}"
{% endfor %}
{% endmacro %}
+
+{% macro azure_set_sccache_envvars(sccache_key_prefix = "sccache") %}
+ {% set sccache_vars = {
+ "AWS_SECRET_ACCESS_KEY": '$(AWS_SECRET_ACCESS_KEY)',
+ "AWS_ACCESS_KEY_ID": '$(AWS_ACCESS_KEY_ID)',
+ "SCCACHE_BUCKET": '$(SCCACHE_BUCKET)',
+ "SCCACHE_S3_KEY_PREFIX": sccache_key_prefix
+ }
+ %}
Review Comment:
```suggestion
%}
```
##########
ci/docker/conda-integration.dockerfile:
##########
@@ -36,7 +36,8 @@ RUN mamba install -q -y \
maven=${maven} \
nodejs=${node} \
yarn \
- openjdk=${jdk} && \
+ openjdk=${jdk} \
+ sccache && \
Review Comment:
Could you sort this list in alphabetical order?
##########
dev/tasks/macros.jinja:
##########
@@ -383,3 +383,16 @@ on:
{{ key }}: "{{ value }}"
{% endfor %}
{% endmacro %}
+
+{% macro azure_set_sccache_envvars(sccache_key_prefix = "sccache") %}
+ {% set sccache_vars = {
+ "AWS_SECRET_ACCESS_KEY": '$(AWS_SECRET_ACCESS_KEY)',
+ "AWS_ACCESS_KEY_ID": '$(AWS_ACCESS_KEY_ID)',
Review Comment:
Could you sort this list in alphabetical order?
##########
dev/tasks/r/github.macos.brew.yml:
##########
@@ -27,17 +27,20 @@ jobs:
{{ macros.github_checkout_arrow()|indent }}
{{ macros.configure_homebrew_arrow(formula)|indent }}
-
+
Review Comment:
```suggestion
```
##########
dev/tasks/macros.jinja:
##########
@@ -383,3 +383,16 @@ on:
{{ key }}: "{{ value }}"
{% endfor %}
{% endmacro %}
+
+{% macro azure_set_sccache_envvars(sccache_key_prefix = "sccache") %}
+ {% set sccache_vars = {
Review Comment:
```suggestion
{% set sccache_vars = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org