You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/11/04 08:58:01 UTC

[GitHub] [incubator-yunikorn-core] FrankinRUC commented on pull request #217: [YUNIKORN-444] Add tracer implementation for scheduling process in the core

FrankinRUC commented on pull request #217:
URL: https://github.com/apache/incubator-yunikorn-core/pull/217#issuecomment-721601406


   Hi @yangwwei , I add some notes for SchedulerTraceContext and the wrapper. I think we cannot avoid it since we don't have AutoCloseable for spans. We have to finish the spans manually like closing useless resources or flushing buffers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org