[GitHub] [spark-website] attilapiros edited a comment on pull request #307: Add github workflow for checking all doc is generated with the right Jekyll version

[GitBox <gi...@apache.org>]

attilapiros edited a comment on pull request #307:
URL: https://github.com/apache/spark-website/pull/307#issuecomment-783672863


   @HyukjinKwon thanks, this was a great idea. 
   I tried it with some slight modification: simply cherry picked this change into my fork's asf-site branch and pushed it.
   
   It found a problem: the `sitemap.xml` content is different based on the ordering of the sites:
   ```
   diff --git a/site/sitemap.xml b/site/sitemap.xml
   index d39b3a212..b2c4901c6 100644
   --- a/site/sitemap.xml
   +++ b/site/sitemap.xml
   @@ -876,11 +876,11 @@
      <changefreq>weekly</changefreq>
    </url>
    <url>
   -  <loc>https://spark.apache.org/screencasts/</loc>
   +  <loc>https://spark.apache.org/sql/</loc>
      <changefreq>weekly</changefreq>
    </url>
    <url>
   -  <loc>https://spark.apache.org/sql/</loc>
   +  <loc>https://spark.apache.org/screencasts/</loc>
      <changefreq>weekly</changefreq>
    </url>
    <url>
    ```
   This is why I remove this file from the check via "grep -v sitemap.xml".
   
   Here is a successful run for the case when there is no change at all: https://github.com/attilapiros/spark-website/runs/1955870878 
   Here is the result for the temporary commit which contains markdown changes without corresponding HTMLs: https://github.com/attilapiros/spark-website/runs/1955930541
   
   Where the error was:
   ```
   Not all documention was generated and/or not the right Jekyll version was used! Modified / untracked files (excluding sitemap.xml):
   site/new_file.html site/community.html
   Git diff (excluding sitemap.xml):
   diff --git a/site/community.html b/site/community.html
   index c7b3d0369..10b8bf3fc 100644
   --- a/site/community.html
   +++ b/site/community.html
   @@ -207,7 +207,7 @@
    
    <h4>StackOverflow</h4>
    
   -<p>For usage questions and help (e.g. how to use this Spark API), it is recommended you use the 
   +<p>A. For usage questions and help (e.g. how to use this Spark API), it is recommended you use the 
    StackOverflow tag <a href="https://stackoverflow.com/questions/tagged/apache-spark"><code class="language-plaintext highlighter-rouge">apache-spark</code></a> 
    as it is an active forum for Spark users&#8217; questions and answers.</p>
    
   Error: Process completed with exit code 1.
   ```
   
   Finding the `shell: /bin/bash {0}` settings took quite a long time. The simple `bash` setting falled back to Bourne Shell.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org