[jira] Commented: (THRIFT-1045) Support "included"ed thrift files

["Henrique Mendonca (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995279#comment-12995279 ] 

Henrique Mendonca commented on THRIFT-1045:
-------------------------------------------

Hey guys,
Thanks for the good work. The generated JS's also work a lot better now!
However, apparently we have a little problem with _const_ definitions here.
After this patch I got a Segmentation fault by JS generation 
*thrift-trunk/test$ _thrift --gen js SmallTest.thrift_*

it works if I remove the following lines from _SmallTest.thrift_
{quote}
const map<i32,map<i32,i32>> CMAP = \{ 235: \{235:235}, 53:\{53:53} }
const i32 CINT = 325;
{quote}

and it was working in revision 1062279 ...
Cheers

> Support "included"ed thrift files
> ---------------------------------
>
>                 Key: THRIFT-1045
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1045
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Compiler
>    Affects Versions: 0.6
>            Reporter: Wade Simmons
>            Assignee: Roger Meier
>         Attachments: nodejs-thrift-imports.patch
>
>
> The current version of the Node.js compiler doesn't support thrift files that "include" other thrift files. This patch imports and references them properly.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira