You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/11/30 01:49:46 UTC

[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #779: GUACAMOLE-1772: Allow user configuration of KSM API call timeout.

mike-jumper commented on code in PR #779:
URL: https://github.com/apache/guacamole-client/pull/779#discussion_r1035450916


##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/conf/KsmConfigurationService.java:
##########
@@ -176,6 +188,20 @@ public boolean getMatchUserRecordsByDomain() throws GuacamoleException {
         return environment.getProperty(MATCH_USER_DOMAINS, false);
     }
 
+    /**
+     * Return the minimum number of milliseconds between KSM API calls. If not
+     * otherwise configured, this value will be 60 seconds.
+     *
+     * @return
+     *     The minimum number of milliseconds between KSM API calls.
+     *
+     * @throws GuacamoleException
+     *     If the value specified within guacamole.properties cannot be
+     *     parsed or does not exist.
+     */
+    public long getKsmApiTimeout() throws GuacamoleException {
+        return environment.getProperty(KSM_API_CALL_TIMEOUT, 60000L);

Review Comment:
   I'm not sure about this. Defaulting to 60 seconds would mean people will not see changes made to records until a full minute has elapsed, which could be surprising behavior for an admin troubleshooting a connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org