[GitHub] [superset] michael-hoffman-26 commented on pull request #18968: feat(importDashboard): import api, add config_overwrite field.

[GitBox <gi...@apache.org>]

michael-hoffman-26 commented on pull request #18968:
URL: https://github.com/apache/superset/pull/18968#issuecomment-1074066430


   Hi, @yousoph thanks for going over this PR.  
   About this:  
   >A few thoughts:
   
   1. Totaly agree, can be done in farther PR.
   2. I did write a warning message with `Overwriting warning msg`,  
   "Overwriting might cause you to lose ....".
   If the user types `CONFIRM` the configuration will be loaded., otherwise it won't.  
   3. I see 2 options for the import flow
   
   #### Option one 
   Exactly your flow, what that you suggested.  
   
   
   #### Option two.
   - Select file.
   - config the overwrite under advance settings.
   - import the model, with configuration attached.
   
   This way when uploading we will do exactly what the configuration setup says.  
   If we passed false in the configuration,   
   1. no overwritten will be done.   
   2. we won't tell the user warning about `you are going to overwrite, please confirm overwrite....` because he determine no overwrite will be done.    
   
   
   in my solution right now I saved a backup capability to the old flow.  
   But after we config the overwrite, I don't see why we should keep warning the user if he is about to overwrite.   
   
   So we need to agree on the right flow, and then I will continue.  
   I do see a common sense in your flow as well
   But I wanted to show our point of view.
   
   Tnx
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org