You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Luke Cwik (JIRA)" <ji...@apache.org> on 2018/01/19 19:04:00 UTC

[jira] [Commented] (BEAM-3493) Prevent users from "implementing" PipelineOptions

    [ https://issues.apache.org/jira/browse/BEAM-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332765#comment-16332765 ] 

Luke Cwik commented on BEAM-3493:
---------------------------------

We could just make sure that Pipeline.create(PipelineOptions) ensures that PipelineOptions is always a proxy class of ProxyInvocationHandler. This would prevent people from creating concrete implementations and any that are created would be ok to break since they wouldn't be able to function with the Apache Beam APIs.

> Prevent users from "implementing" PipelineOptions
> -------------------------------------------------
>
>                 Key: BEAM-3493
>                 URL: https://issues.apache.org/jira/browse/BEAM-3493
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Luke Cwik
>            Priority: Major
>              Labels: newbie, starter
>
> I've seen a user implement \{{PipelineOptions}}. This implies that it is backwards-incompatible to add new options, which is of course not our intent. We should at least document very loudly that it is not to be implemented, and preferably have some automation that will fail on load if they have implemented it. Ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)