You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by czxrrr <gi...@git.apache.org> on 2018/07/27 23:27:14 UTC
[GitHub] orc pull request #296: [c++] column/field name can take underline
GitHub user czxrrr opened a pull request:
https://github.com/apache/orc/pull/296
[c++] column/field name can take underline
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/czxrrr/orc ORC-391
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 6edfb5e30651b767dc0b90eef33ac08ad41c65c5
Author: zherui cao <zh...@...>
Date: 2018-07-27T23:18:16Z
[c++] column/field name can take underline
----
---
[GitHub] orc issue #296: [ORC-391][c++] parseType does not accept underscore in the f...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/296
+1 LGTM. Thanks.
---
[GitHub] orc issue #296: [c++] column/field name can take underline
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/296
JIRA name and a test please!
---
[GitHub] orc pull request #296: [ORC-391][c++] parseType does not accept underscore i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/296
---
[GitHub] orc pull request #296: [ORC-391][c++] parseType does not accept underscore i...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/296#discussion_r206153654
--- Diff: tools/test/TestCSVFileImport.cc ---
@@ -53,3 +53,33 @@ TEST (TestCSVFileImport, test10rows) {
EXPECT_EQ(expected, output);
EXPECT_EQ("", error);
}
+
+TEST (TestCSVFileImport, test10rows_underscore) {
+ // create an ORC file from importing the CSV file
+ const std::string pgm1 = findProgram("tools/src/csv-import");
+ const std::string csvFile = findExample("TestCSVFileImport.test10rows.csv");
+ const std::string orcFile = "/tmp/test_csv_import_test_10_rows.orc";
+ const std::string schema = "struct<_a:bigint,b_:string,c:double>";
--- End diff --
Thanks for the test! can you rename `c` to `c_col`?
---