You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by Bryant Luk <br...@gmail.com> on 2010/07/22 21:36:59 UTC
Re: svn commit: r966803 - in /incubator/wink/trunk:
wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/
wink-client/src/main/java/org/apache/wink/client/ wink-client/src/main/java/org/apache/wink/client/handlers/
win
I think we should revert the BasicAuthClientHandler change. We
originally had this set to username and password but I don't think we
should just read for "user" and "password" system properties. For the
properties file read and other system properties, if a user wanted to
read from a properties file or to read a system property, they could
do it in their own code.
On Thu, Jul 22, 2010 at 1:56 PM, <ro...@apache.org> wrote:
> Author: rott
> Date: Thu Jul 22 18:56:55 2010
> New Revision: 966803
>
> URL: http://svn.apache.org/viewvc?rev=966803&view=rev
> Log:
> WINK-305: improve SSL configuration options to allow properties file config
>
> Modified:
> incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/ApacheHttpClientConnectionHandler.java
> incubator/wink/trunk/wink-client/src/main/java/org/apache/wink/client/ClientConfig.java
> incubator/wink/trunk/wink-client/src/main/java/org/apache/wink/client/handlers/BasicAuthSecurityHandler.java
> incubator/wink/trunk/wink-client/src/main/java/org/apache/wink/client/internal/handlers/HttpURLConnectionHandler.java
> incubator/wink/trunk/wink-common/src/main/java/org/apache/wink/common/internal/registry/metadata/AbstractMetadataCollector.java
> incubator/wink/trunk/wink-common/src/main/java/org/apache/wink/common/internal/registry/metadata/ProviderMetadataCollector.java
> incubator/wink/trunk/wink-common/src/test/java/org/apache/wink/common/internal/registry/metadata/ProviderMetadataCollectorTest.java
> incubator/wink/trunk/wink-server/pom.xml
> incubator/wink/trunk/wink-server/src/main/java/org/apache/wink/server/internal/DeploymentConfiguration.java
> incubator/wink/trunk/wink-server/src/main/java/org/apache/wink/server/internal/servlet/RestFilter.java
Re: svn commit: r966803 - in /incubator/wink/trunk:
wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/
wink-client/src/main/java/org/apache/wink/client/ wink-client/src/main/java/org/apache/wink/client/handlers/
win
Posted by Mike Rheinheimer <ro...@apache.org>.
Yeah, agree. Managing a properties file, testing it, etc, is really
beyond the scope of Wink. We'd have to document it, maintain it, etc.
Reading a properties file is trivial, and should be left to the
end-user.
Will revert it and remark in WINK-305 where that revert took place.
Thanks.
mike
On Thu, Jul 22, 2010 at 2:36 PM, Bryant Luk <br...@gmail.com> wrote:
> I think we should revert the BasicAuthClientHandler change. We
> originally had this set to username and password but I don't think we
> should just read for "user" and "password" system properties. For the
> properties file read and other system properties, if a user wanted to
> read from a properties file or to read a system property, they could
> do it in their own code.
>
> On Thu, Jul 22, 2010 at 1:56 PM, <ro...@apache.org> wrote:
>> Author: rott
>> Date: Thu Jul 22 18:56:55 2010
>> New Revision: 966803
>>
>> URL: http://svn.apache.org/viewvc?rev=966803&view=rev
>> Log:
>> WINK-305: improve SSL configuration options to allow properties file config
>>
>> Modified:
>> incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/ApacheHttpClientConnectionHandler.java
>> incubator/wink/trunk/wink-client/src/main/java/org/apache/wink/client/ClientConfig.java
>> incubator/wink/trunk/wink-client/src/main/java/org/apache/wink/client/handlers/BasicAuthSecurityHandler.java
>> incubator/wink/trunk/wink-client/src/main/java/org/apache/wink/client/internal/handlers/HttpURLConnectionHandler.java
>> incubator/wink/trunk/wink-common/src/main/java/org/apache/wink/common/internal/registry/metadata/AbstractMetadataCollector.java
>> incubator/wink/trunk/wink-common/src/main/java/org/apache/wink/common/internal/registry/metadata/ProviderMetadataCollector.java
>> incubator/wink/trunk/wink-common/src/test/java/org/apache/wink/common/internal/registry/metadata/ProviderMetadataCollectorTest.java
>> incubator/wink/trunk/wink-server/pom.xml
>> incubator/wink/trunk/wink-server/src/main/java/org/apache/wink/server/internal/DeploymentConfiguration.java
>> incubator/wink/trunk/wink-server/src/main/java/org/apache/wink/server/internal/servlet/RestFilter.java
>