You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by dm...@apache.org on 2022/05/26 09:54:48 UTC

[trafficserver] branch 10-Dev updated: Fix traffic_ctl server drain(undo) jsonrpc api call. It was wrongly calling admin_server_start_drain when it was supposed to call admin_server_stop_drain. (#8856)

This is an automated email from the ASF dual-hosted git repository.

dmeden pushed a commit to branch 10-Dev
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/10-Dev by this push:
     new d68719dab Fix traffic_ctl server drain(undo) jsonrpc api call. It was wrongly calling admin_server_start_drain when it was supposed to call admin_server_stop_drain. (#8856)
d68719dab is described below

commit d68719daba718f25736c7d98f005212200f411ef
Author: Damian Meden <da...@gmail.com>
AuthorDate: Thu May 26 10:54:41 2022 +0100

    Fix traffic_ctl server drain(undo) jsonrpc api call. It was wrongly calling admin_server_start_drain when it was supposed to call admin_server_stop_drain. (#8856)
---
 src/traffic_ctl_jsonrpc/jsonrpc/CtrlRPCRequests.h | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/traffic_ctl_jsonrpc/jsonrpc/CtrlRPCRequests.h b/src/traffic_ctl_jsonrpc/jsonrpc/CtrlRPCRequests.h
index 9ac85d379..cc0349287 100644
--- a/src/traffic_ctl_jsonrpc/jsonrpc/CtrlRPCRequests.h
+++ b/src/traffic_ctl_jsonrpc/jsonrpc/CtrlRPCRequests.h
@@ -170,11 +170,7 @@ struct ServerStartDrainRequest : shared::rpc::ClientRequest {
   struct Params {
     bool waitForNewConnections{false};
   };
-  ServerStartDrainRequest(Params p)
-  {
-    super::method = "admin_server_start_drain";
-    super::params = p;
-  }
+  ServerStartDrainRequest(Params p) { super::params = p; }
   std::string
   get_method() const override
   {
@@ -187,7 +183,7 @@ struct ServerStopDrainRequest : shared::rpc::ClientRequest {
   std::string
   get_method() const override
   {
-    return "admin_server_start_drain";
+    return "admin_server_stop_drain";
   }
 };
 //------------------------------------------------------------------------------------------------------------------------------------