You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "coldgust (via GitHub)" <gi...@apache.org> on 2023/03/27 15:47:40 UTC
[GitHub] [incubator-devlake] coldgust opened a new pull request, #4789: fix: test teambition connection
coldgust opened a new pull request, #4789:
URL: https://github.com/apache/incubator-devlake/pull/4789
### Summary
fix teambition set the wrong code when test connection
### Does this close any open issues?
Closes xx
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] coldgust commented on pull request #4789: fix: test teambition connection
Posted by "coldgust (via GitHub)" <gi...@apache.org>.
coldgust commented on PR #4789:
URL: https://github.com/apache/incubator-devlake/pull/4789#issuecomment-1490302756
@klesh , thanks for the reminder.
I think `errorMessage` is helpful for users too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #4789: fix: test teambition connection
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #4789:
URL: https://github.com/apache/incubator-devlake/pull/4789#issuecomment-1487834761
Hi, @coldgust . Thank you for the information, 👍
Seems like their API design is a little bit off.
However, there is no proof to show the `code` inside the response body is `Http Status Code`, we should hardcode our API status code to 400 unless it can be proven.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] coldgust commented on pull request #4789: fix: test teambition connection
Posted by "coldgust (via GitHub)" <gi...@apache.org>.
coldgust commented on PR #4789:
URL: https://github.com/apache/incubator-devlake/pull/4789#issuecomment-1558505071
#5066 have solved this issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] coldgust closed pull request #4789: fix: test teambition connection
Posted by "coldgust (via GitHub)" <gi...@apache.org>.
coldgust closed pull request #4789: fix: test teambition connection
URL: https://github.com/apache/incubator-devlake/pull/4789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #4789: fix: test teambition connection
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #4789:
URL: https://github.com/apache/incubator-devlake/pull/4789#issuecomment-1486262374
Hi, @coldgust , thank you for the fix.
Please describe why you think this is the right way, did you find it out on their document? if so, please attach a link to the document, thanks.
Please attach screenshots to show the new code is working correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] coldgust commented on pull request #4789: fix: test teambition connection
Posted by "coldgust (via GitHub)" <gi...@apache.org>.
coldgust commented on PR #4789:
URL: https://github.com/apache/incubator-devlake/pull/4789#issuecomment-1487246371
Hi, @klesh
The teambition api alaways return `200` http code, it needs to check the `code` in response.
https://open.teambition.com/docs/apis/6321c6ce912d20d3b5a489ee
The new code show the `code` in response
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #4789: fix: test teambition connection
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #4789:
URL: https://github.com/apache/incubator-devlake/pull/4789#issuecomment-1489576486
@coldgust Thanks for the update.
I just notice another thing: seems like the response offered a field named `errorMessage`, do you think it is helpful for users to understand what went wrong if we put it into our error?
Sorry for missing it before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org