You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/08/03 01:34:34 UTC
Review Request: Added the ability to "iterate" over the variable names
currently in the state.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6324/
-----------------------------------------------------------
Review request for mesos, John Sirois and Florian Leibert.
Description
-------
See summary.
Diffs
-----
src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c4dc68d
src/java/src/org/apache/mesos/state/InMemoryState.java 82d5f48
src/java/src/org/apache/mesos/state/State.java 2e2e060
src/java/src/org/apache/mesos/state/ZooKeeperState.java 3b4c035
src/state/leveldb.hpp cc9e92e
src/state/leveldb.cpp 3ee68c4
src/state/state.hpp 9ae713b
src/state/zookeeper.hpp b03f9fe
src/state/zookeeper.cpp 0cc8580
src/tests/state_tests.cpp a3dabe8
src/zookeeper/group.cpp 68c38cb
src/zookeeper/zookeeper.hpp 5e22d52
src/zookeeper/zookeeper.cpp d364ebf
Diff: https://reviews.apache.org/r/6324/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added the ability to "iterate" over the variable names
currently in the state.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 3, 2012, 12:28 a.m., John Sirois wrote:
> >
Thanks, submitting.
> On Aug. 3, 2012, 12:28 a.m., John Sirois wrote:
> > src/java/src/org/apache/mesos/state/State.java, line 52
> > <https://reviews.apache.org/r/6324/diff/1/?file=133633#file133633line52>
> >
> > This looks left over from my wild goose chase and should be reverted for a simpler to read client API
Done.
> On Aug. 3, 2012, 12:28 a.m., John Sirois wrote:
> > src/state/zookeeper.cpp, line 282
> > <https://reviews.apache.org/r/6324/diff/1/?file=133639#file133639line282>
> >
> > Agreed _mesos_state_[name] or something similar is clear but also allows playing with others if a user wants to group more stuff under the state path.
Till next time.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6324/#review9795
-----------------------------------------------------------
On Aug. 2, 2012, 11:34 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6324/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2012, 11:34 p.m.)
>
>
> Review request for mesos, John Sirois and Florian Leibert.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c4dc68d
> src/java/src/org/apache/mesos/state/InMemoryState.java 82d5f48
> src/java/src/org/apache/mesos/state/State.java 2e2e060
> src/java/src/org/apache/mesos/state/ZooKeeperState.java 3b4c035
> src/state/leveldb.hpp cc9e92e
> src/state/leveldb.cpp 3ee68c4
> src/state/state.hpp 9ae713b
> src/state/zookeeper.hpp b03f9fe
> src/state/zookeeper.cpp 0cc8580
> src/tests/state_tests.cpp a3dabe8
> src/zookeeper/group.cpp 68c38cb
> src/zookeeper/zookeeper.hpp 5e22d52
> src/zookeeper/zookeeper.cpp d364ebf
>
> Diff: https://reviews.apache.org/r/6324/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added the ability to "iterate" over the variable names
currently in the state.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6324/#review9795
-----------------------------------------------------------
Ship it!
src/java/src/org/apache/mesos/state/State.java
<https://reviews.apache.org/r/6324/#comment20783>
This looks left over from my wild goose chase and should be reverted for a simpler to read client API
src/state/zookeeper.cpp
<https://reviews.apache.org/r/6324/#comment20785>
Agreed _mesos_state_[name] or something similar is clear but also allows playing with others if a user wants to group more stuff under the state path.
- John Sirois
On Aug. 2, 2012, 11:34 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6324/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2012, 11:34 p.m.)
>
>
> Review request for mesos, John Sirois and Florian Leibert.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c4dc68d
> src/java/src/org/apache/mesos/state/InMemoryState.java 82d5f48
> src/java/src/org/apache/mesos/state/State.java 2e2e060
> src/java/src/org/apache/mesos/state/ZooKeeperState.java 3b4c035
> src/state/leveldb.hpp cc9e92e
> src/state/leveldb.cpp 3ee68c4
> src/state/state.hpp 9ae713b
> src/state/zookeeper.hpp b03f9fe
> src/state/zookeeper.cpp 0cc8580
> src/tests/state_tests.cpp a3dabe8
> src/zookeeper/group.cpp 68c38cb
> src/zookeeper/zookeeper.hpp 5e22d52
> src/zookeeper/zookeeper.cpp d364ebf
>
> Diff: https://reviews.apache.org/r/6324/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>