You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/09 20:18:30 UTC
[GitHub] [airflow] ashb opened a new pull request #12210: Change table formatting to reduce git diffs in provider READMEs
ashb opened a new pull request #12210:
URL: https://github.com/apache/airflow/pull/12210
Rather than formatting all the columns, which means that any time a new
longer commit happens _all_ rows in the table get re-formatted, this
keeps things "tight" so that only changed lines are changed.
What do you think @potiuk?
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #12210: Change table formatting to reduce git diffs in provider READMEs
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #12210:
URL: https://github.com/apache/airflow/pull/12210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12210: Change table formatting to reduce git diffs in provider READMEs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12210:
URL: https://github.com/apache/airflow/pull/12210#issuecomment-724272877
Those tables are not going to be updated.
Each table is separate from each other (each release has one table per provider) and once we release, each release has its own, separate table with its own length - not impacting other tables. The table might get updated only while you are rebasing the PR before it gets merged (in which case it has no impact whether all rows change or not). Once it is merged, the table is "fixed".
I personally I prefer the tabulate one as they are easier and nicer to see in text format, I think this is what tabulate nicely solves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12210: Change table formatting to reduce git diffs in provider READMEs
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12210:
URL: https://github.com/apache/airflow/pull/12210#issuecomment-724279637
Ah if they aren't going to be updated (very often) that's cool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12210: Change table formatting to reduce git diffs in provider READMEs
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12210:
URL: https://github.com/apache/airflow/pull/12210#issuecomment-724265111
(Either way not merging this before beta1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12210: Change table formatting to reduce git diffs in provider READMEs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12210:
URL: https://github.com/apache/airflow/pull/12210#issuecomment-724288446
> Ah if they aren't going to be updated (very often) that's cool.
They won't change once merged :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org