[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #604: MINIFICPP-926 Create nanofi tailfile processor for tailing file by configurable chunk size

[GitBox <gi...@apache.org>]

bakaid commented on a change in pull request #604: MINIFICPP-926 Create nanofi tailfile processor for tailing file by configurable chunk size
URL: https://github.com/apache/nifi-minifi-cpp/pull/604#discussion_r300622916
 
 

 ##########
 File path: nanofi/include/api/ecu.h
 ##########
 @@ -0,0 +1,44 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+    *
+    *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+
+#ifndef NANOFI_INCLUDE_API_ECU_H_
+#define NANOFI_INCLUDE_API_ECU_H_
+
+#include "api/nanofi.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+extern nifi_instance * instance;
+extern standalone_processor * proc;
+extern flow_file_list ff_list;
+extern int curr_offset;
+extern int stopped;
 
 Review comment:
   This should be a volatile sig_atomic_t, see https://wiki.sei.cmu.edu/confluence/display/c/SIG31-C.+Do+not+access+shared+objects+in+signal+handlers

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services