You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/03/13 10:47:51 UTC

[GitHub] incubator-brooklyn pull request: Fix AbstractEntity.config()

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/550

    Fix AbstractEntity.config()

    - When return type of config() was changed to BasicConfigurationSupport,
      it broke any entity impls that tried to call config().set(...) etc
    - Solution is to change BasicConfigurationSupport to be protected
      rather than private, and mark as @Beta because we’ll change it
      back to private at some point.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/AbstractEntity-config-method

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/550.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #550
    
----
commit 6d548e9a9722de1a7adcefbb3b9ae1365b33c728
Author: Aled Sage <al...@gmail.com>
Date:   2015-03-13T09:47:11Z

    Fix AbstractEntity.config()
    
    - When return type of config() was changed to BasicConfigurationSupport,
      it broke any entity impls that tried to call config().set(...) etc
    - Solution is to change BasicConfigurationSupport to be protected
      rather than private, and mark as @Beta because we’ll change it
      back to private at some point.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix AbstractEntity.config()

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/550


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix AbstractEntity.config()

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/550#issuecomment-78892592
  
    lgtm - shame we have to jump through this groovy hoop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---