You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/14 13:55:00 UTC
[jira] [Work logged] (BEAM-3634) [SQL] Refactor BeamRelNodes into
PTransforms
[ https://issues.apache.org/jira/browse/BEAM-3634?focusedWorklogId=101733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-101733 ]
ASF GitHub Bot logged work on BEAM-3634:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/18 13:54
Start Date: 14/May/18 13:54
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #4705: [BEAM-3634] Refactor BeamRelNode to return a PTransform
URL: https://github.com/apache/beam/pull/4705#issuecomment-388824982
@apilloud it occurred to me that this PR of mine probably is a source of some of the UI issues that you noticed. Before this PR I think the graph layout would have been more "top-to-bottom" and less "nested boxes".
I think a middle ground would be best
- having the explicit PTransforms at each node is nice for getting the composite structure
- but the recursion into sub-nodes needs to happen outside of that PTransform's `apply` method to get top-to-bottom layout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 101733)
Time Spent: 2h 20m (was: 2h 10m)
> [SQL] Refactor BeamRelNodes into PTransforms
> --------------------------------------------
>
> Key: BEAM-3634
> URL: https://issues.apache.org/jira/browse/BEAM-3634
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> BeamRelNode exposes PCollection<BeamRecord> buildBeamPipeline() which builds a pipeline when parsing.
> It feels like it should instead implement a PTransform<PCollection<BeamRecord>, PCollection<BeamRecord>> which would receive a prepared PCollection, and apply sub-expressions instead of manually invoking expression evaluation to get the input.
> And maybe consider building it lazily.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)