You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/07 11:56:31 UTC

[GitHub] [arrow] jorgecarleitao commented on pull request #8608: ARROW-10261: [Rust] [Breaking] Change List datatype to Box

jorgecarleitao commented on pull request #8608:
URL: https://github.com/apache/arrow/pull/8608#issuecomment-723436980


   Ready to merge if the tests pass. I went through all the changes and they seem reasonable. Most issues I had were the same that @alamb suggested, and the rest seems straightforward given the changes on the DataType.
   
   I have a question related to why do we use a `Box<>` instead of just putting it into the stack, but other parts of the code have that, and thus makes sense to keep it as is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org