[jira] [Commented] (IGNITE-9741) SegmentArchivedStorage and SegmentCompressStorage remain `iterrupted` after de-activation occurs before activation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633761#comment-16633761 ] 

ASF GitHub Bot commented on IGNITE-9741:
----------------------------------------

GitHub user akalash opened a pull request:

    https://github.com/apache/ignite/pull/4878

    IGNITE-9741 SegmentAware recreated every activation

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-9741

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4878
    
----
commit 3877ea5ec9b9e4e602ccce198c60ecfff07f8904
Author: Anton Kalashnikov <ka...@...>
Date:   2018-10-01T09:26:01Z

    IGNITE-9741 SegmentAware recreated every activation

----


> SegmentArchivedStorage and SegmentCompressStorage remain `iterrupted` after de-activation occurs before activation
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-9741
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9741
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Maxim Muzafarov
>            Assignee: Anton Kalashnikov
>            Priority: Critical
>             Fix For: 2.7
>
>
> The {{FileWriteAheadLogManager}} now contains:
>  {{private final SegmentAware segmentAware;}}
>  
> The SegmentAware have the `interrupt()` method:
> {code:java|title=SegmentAware:216}
>     /**
>      * Interrupt waiting on related objects.
>      */
>     public void interrupt() {
>         segmentArchivedStorage.interrupt();
>         segmentCompressStorage.interrupt();
>         segmentCurrStateStorage.interrupt();
>     }
> {code}
>  
> Method at the {{FileWriteAheadLogManager}} de-activation sets (e.g. for SegmentArchivedStorage) `interrupted` filed to `true` value but never revert it to `false` after activation.
> {code:java|title=SegmentArchivedStorage:114}
>     /**
>      * Interrupt waiting on this object.
>      */
>     synchronized void interrupt() {
>         interrupted = true;
>         notifyAll();
>     }
> {code}
>  
> So, the SegmentArchivedStorage after de-activation always remain interrupted. 
>  This can lead to undefined behaviour e.g. exchange worker hangs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)