Re: [PR] chore(backend): Bump SQLAlchemy to version 2. [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #39735:
URL: https://github.com/apache/superset/pull/39735#issuecomment-4737056985

   Hey @hy144328 - now that #40276 is merged, a good chunk of this is already on `master` (the `select()` changes across the importers, `models.py`, the old migrations...), and #40275 covers the `case()` bits once it's rebased. So if you rebase this, I think it collapses down to mostly the version pin + requirements regen.
   
   I also pulled the rest of the forward-compat work that doesn't overlap with your carve-outs into #41179 - the `BaseQuery` shim, `eagerload`→`joinedload`, `VisitableType`→`TypeEngine`, the `engine.execute`/raw-SQL `text()` fixes, plus some prospective `Mapped[...]` annotations. All backward-compatible with 1.4, so it can land ahead of the bump. Between that, your carve-outs, and the pin here, I think we're basically there.
   
   Mind rebasing this so we can see exactly what's left? Then we can sort out whether the final pin rides this PR or the dependabot one (#40830). Thanks for driving all of this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org