You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/20 05:03:32 UTC

[GitHub] [shardingsphere] yx9o commented on a diff in pull request #16941: Modify the test case configuration file (#16916, #16933)

yx9o commented on code in PR #16941:
URL: https://github.com/apache/shardingsphere/pull/16941#discussion_r853728180


##########
examples/shardingsphere-jdbc-example/single-feature-example/sharding-example/sharding-raw-jdbc-example/src/main/resources/META-INF/sharding-databases-range.yaml:
##########
@@ -58,6 +58,7 @@ rules:
     - t_address
   defaultDatabaseStrategy:
     standard:
+      shardingColumn: user_id

Review Comment:
   Hi, I think it is better to use `defaultShardingColumn` here, need to modify the code in `ShardingRule`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org