You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2023/04/14 16:33:49 UTC
[GitHub] [accumulo-website] DomGarguilo opened a new pull request, #383: Fix Teardown documentation
DomGarguilo opened a new pull request, #383:
URL: https://github.com/apache/accumulo-website/pull/383
Addresses concerns about the 2.x documentation from https://github.com/apache/accumulo/issues/3287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] DomGarguilo commented on pull request #383: Fix Teardown documentation
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#issuecomment-1508949848
Once these changes are finalized I'll make a PR to incorporate them into 1.10 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ivakegg commented on a diff in pull request #383: Fix Teardown documentation
Posted by "ivakegg (via GitHub)" <gi...@apache.org>.
ivakegg commented on code in PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#discussion_r1167061179
##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
### Teardown
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+As mentioned, instances of iterators may be torn down inside the server transparently. When a
+complex collection of iterators is performing some advanced functionality, they will not be torn
+down until a Key-Value pair is returned out of the "stack" of iterators (and added into the batch of
+Key-Values to be returned to the caller). Being torn down means that the iterator stack is recreated
Review Comment:
... to be returned to the caller), or the iterator is yielded. Being torn down means ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] DomGarguilo commented on a diff in pull request #383: Fix Teardown documentation
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#discussion_r1167191226
##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
### Teardown
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+As mentioned, instances of iterators may be torn down inside the server transparently. When a
+complex collection of iterators is performing some advanced functionality, they will not be torn
+down until a Key-Value pair is returned out of the "stack" of iterators (and added into the batch of
+Key-Values to be returned to the caller), or the iterator is yielded. Being torn down means that the
Review Comment:
Tried to incorporate these ideas in dce94ec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] Manno15 commented on a diff in pull request #383: Fix Teardown documentation
Posted by "Manno15 (via GitHub)" <gi...@apache.org>.
Manno15 commented on code in PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#discussion_r1167593585
##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
### Teardown
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+Instances of iterators may be torn down inside the server transparently. When a complex collection
+of iterators is performing advanced functionality, they will not be torn down until a Key-Value pair
+is returned out of the "stack" of iterators (and added into the batch of Key-Values to be returned
+to the caller), or the iterator is yielded.
+
+When an iterator is torn down, the entire stack is dropped and no state is preserved. Only the last
+key returned (or the yielded position), original options, and seek range are retained. When the scan
+is continued, the iterator stack is rebuilt, re-initialized using the original options. The stack
+is then seeked with the original range, and the start key is replaced by the last key returned (or
Review Comment:
```suggestion
key returned (or the yielded position), original options, and seek range are retained. When the scan
is continued, the iterator stack is rebuilt and re-initialized using the original options. The stack
is then seeked with the original range, and the start key is replaced by the last key returned (or
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ivakegg commented on a diff in pull request #383: Fix Teardown documentation
Posted by "ivakegg (via GitHub)" <gi...@apache.org>.
ivakegg commented on code in PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#discussion_r1167103684
##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
### Teardown
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+As mentioned, instances of iterators may be torn down inside the server transparently. When a
+complex collection of iterators is performing some advanced functionality, they will not be torn
+down until a Key-Value pair is returned out of the "stack" of iterators (and added into the batch of
+Key-Values to be returned to the caller), or the iterator is yielded. Being torn down means that the
Review Comment:
Being torn down means that the iterator stack is completely dropped, and the only information retained is that last key returned (or the yielded position) along with the original options and seek range. When the scan is continued, then the iterator stack is rebuilt, re-initialized using the original options, and then seeked using the original range with the start key replaced by the last key returned (or the yielded position), non-inclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] DomGarguilo commented on a diff in pull request #383: Fix Teardown documentation
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#discussion_r1167071366
##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
### Teardown
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+As mentioned, instances of iterators may be torn down inside the server transparently. When a
+complex collection of iterators is performing some advanced functionality, they will not be torn
+down until a Key-Value pair is returned out of the "stack" of iterators (and added into the batch of
+Key-Values to be returned to the caller). Being torn down means that the iterator stack is recreated
+as new instances with the original options, and then it is seeked from where it left off. References
+to the old instances are removed and the objects are lazily garbage collected by the JVM.
Review Comment:
Addressed in fd55b58
##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
### Teardown
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+As mentioned, instances of iterators may be torn down inside the server transparently. When a
+complex collection of iterators is performing some advanced functionality, they will not be torn
+down until a Key-Value pair is returned out of the "stack" of iterators (and added into the batch of
+Key-Values to be returned to the caller). Being torn down means that the iterator stack is recreated
Review Comment:
Addressed in fd55b58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ivakegg commented on a diff in pull request #383: Fix Teardown documentation
Posted by "ivakegg (via GitHub)" <gi...@apache.org>.
ivakegg commented on code in PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#discussion_r1167062530
##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
### Teardown
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+As mentioned, instances of iterators may be torn down inside the server transparently. When a
+complex collection of iterators is performing some advanced functionality, they will not be torn
+down until a Key-Value pair is returned out of the "stack" of iterators (and added into the batch of
+Key-Values to be returned to the caller). Being torn down means that the iterator stack is recreated
+as new instances with the original options, and then it is seeked from where it left off. References
+to the old instances are removed and the objects are lazily garbage collected by the JVM.
Review Comment:
The sentence about the references to the old instances being garbace collected can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] DomGarguilo merged pull request #383: Fix Teardown documentation
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #383:
URL: https://github.com/apache/accumulo-website/pull/383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org