You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/28 02:58:19 UTC
[GitHub] [doris] nextdreamblue opened a new pull request, #10464: [Bug] fix create table like when having sequence column
nextdreamblue opened a new pull request, #10464:
URL: https://github.com/apache/doris/pull/10464
# Proposed changes
Issue Number: close #10463
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10464: [Bug] fix create table like when having sequence column
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10464:
URL: https://github.com/apache/doris/pull/10464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on a diff in pull request #10464: [Bug] fix create table like when having sequence column
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on code in PR #10464:
URL: https://github.com/apache/doris/pull/10464#discussion_r910677895
##########
regression-test/data/data_model/unique/test_unique_table_like.out:
##########
@@ -5,11 +5,13 @@ int_value INT Yes false \N REPLACE
char_value CHAR(10) Yes false \N REPLACE
date_value DATE Yes false \N REPLACE
__DORIS_DELETE_SIGN__ TINYINT No false 0 REPLACE
+__DORIS_SEQUENCE_COL__ INT Yes false \N REPLACE
Review Comment:
Before fix this bug, when create table b like table a which having column `__DORIS_SEQUENCE_COL__`, i can not get table b with column `__DORIS_SEQUENCE_COL__`.
it is diffrent between able a and table b.
when get schema of table a, return table's `function_column.sequence_type` property, and you will get table b with column `__DORIS_SEQUENCE_COL__ ` like table a.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on a diff in pull request #10464: [Bug] fix create table like when having sequence column
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #10464:
URL: https://github.com/apache/doris/pull/10464#discussion_r909729824
##########
regression-test/data/data_model/unique/test_unique_table_like.out:
##########
@@ -5,11 +5,13 @@ int_value INT Yes false \N REPLACE
char_value CHAR(10) Yes false \N REPLACE
date_value DATE Yes false \N REPLACE
__DORIS_DELETE_SIGN__ TINYINT No false 0 REPLACE
+__DORIS_SEQUENCE_COL__ INT Yes false \N REPLACE
Review Comment:
I don't see the code add `__DORIS_SEQUENCE_COL__`, can you help me point it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10464: [Bug] fix create table like when having sequence column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10464:
URL: https://github.com/apache/doris/pull/10464#issuecomment-1172833581
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10464: [Bug] fix create table like when having sequence column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10464:
URL: https://github.com/apache/doris/pull/10464#issuecomment-1172833586
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org