You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/02 03:40:10 UTC
[kudu-CR] Fix compilation on XCode 11
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14343
Change subject: Fix compilation on XCode 11
......................................................................
Fix compilation on XCode 11
I recently upgraded my Mac to XCode 11 which now fails with:
…/kudu/src/kudu/consensus/quorum_util-test.cc:49:16: error: constexpr variable cannot have non-literal type 'const std::initializer_list<char>'
constexpr auto kHealthStatuses = { '?', '-', 'x', '+' };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/initializer_list:59:28: note: 'initializer_list<char>' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
class _LIBCPP_TEMPLATE_VIS initializer_list
This looks to be realted some ambiquity in compiler support for this syntax:
https://stackoverflow.com/questions/36863503/struct-is-non-literal-type/36863691
I fixed this by converting it to a const instead of a consexpr.
Change-Id: Iad3db5ac4d65fd9bdfa8f357b350f24d0e0d3ec0
---
M src/kudu/consensus/quorum_util-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14343/1
--
To view, visit http://gerrit.cloudera.org:8080/14343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad3db5ac4d65fd9bdfa8f357b350f24d0e0d3ec0
Gerrit-Change-Number: 14343
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Fix compilation on XCode 11
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14343 )
Change subject: Fix compilation on XCode 11
......................................................................
Fix compilation on XCode 11
I recently upgraded my Mac to XCode 11 which now fails with:
…/kudu/src/kudu/consensus/quorum_util-test.cc:49:16: error: constexpr variable cannot have non-literal type 'const std::initializer_list<char>'
constexpr auto kHealthStatuses = { '?', '-', 'x', '+' };
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/initializer_list:59:28: note: 'initializer_list<char>' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors
class _LIBCPP_TEMPLATE_VIS initializer_list
This looks to be realted some ambiquity in compiler support for this syntax:
https://stackoverflow.com/questions/36863503/struct-is-non-literal-type/36863691
I fixed this by converting it to a const instead of a consexpr.
Change-Id: Iad3db5ac4d65fd9bdfa8f357b350f24d0e0d3ec0
Reviewed-on: http://gerrit.cloudera.org:8080/14343
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/consensus/quorum_util-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad3db5ac4d65fd9bdfa8f357b350f24d0e0d3ec0
Gerrit-Change-Number: 14343
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix compilation on XCode 11
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14343 )
Change subject: Fix compilation on XCode 11
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3db5ac4d65fd9bdfa8f357b350f24d0e0d3ec0
Gerrit-Change-Number: 14343
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 05:31:36 +0000
Gerrit-HasComments: No