You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/16 12:13:36 UTC
[GitHub] [hadoop-ozone] bshashikant opened a new pull request #1081: HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it.
bshashikant opened a new pull request #1081:
URL: https://github.com/apache/hadoop-ozone/pull/1081
## What changes were proposed in this pull request?
Added logic to take into account max no of healthy disks reported among the sets
of datanodes of a pipeline to get the total no of open containers per pipeline.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3809
## How was this patch tested?
Added unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #1081: HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it.
Posted by GitBox <gi...@apache.org>.
dineshchitlangia commented on a change in pull request #1081:
URL: https://github.com/apache/hadoop-ozone/pull/1081#discussion_r445004184
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
##########
@@ -608,6 +608,16 @@ public void close() throws IOException {
pipelineFactory.shutdown();
}
+ /**
+ * returns max count of healthy volumes from the set of
+ * datanodes constituting the pipeline
Review comment:
```suggestion
* Returns count of healthy volumes from the set of
* datanodes constituting the pipeline.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1081: HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1081:
URL: https://github.com/apache/hadoop-ozone/pull/1081#discussion_r452326354
##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
##########
@@ -605,6 +616,12 @@ public void setNetworkTopology(NetworkTopology topology) {
this.currentState = currentState;
}
+ NodeData(long capacity, long used, long currentState, long healthyVolumes) {
Review comment:
Parameter `healthyVolumes` is unused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #1081: HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it.
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #1081:
URL: https://github.com/apache/hadoop-ozone/pull/1081#discussion_r454949836
##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
##########
@@ -605,6 +616,12 @@ public void setNetworkTopology(NetworkTopology topology) {
this.currentState = currentState;
}
+ NodeData(long capacity, long used, long currentState, long healthyVolumes) {
Review comment:
Addressed in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1081: HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1081:
URL: https://github.com/apache/hadoop-ozone/pull/1081#issuecomment-665746395
Thanks @bshashikant for the contribution, @elek and @dineshchitlangia for the review. Merged to `master` after latest green run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1081: HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1081:
URL: https://github.com/apache/hadoop-ozone/pull/1081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org