You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/03 16:48:25 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Rendering template_fields without accessing DAG files

kaxil commented on a change in pull request #6788: [AIRFLOW-5944] Rendering template_fields without accessing DAG files
URL: https://github.com/apache/airflow/pull/6788#discussion_r387153601
 
 

 ##########
 File path: airflow/models/dagrun.py
 ##########
 @@ -470,6 +472,12 @@ def verify_integrity(self, session=None):
                     1, 1)
                 ti = TI(task, self.execution_date)
                 session.add(ti)
+                session.commit()
+
+                if STORE_SERIALIZED_DAGS:
+                    RenderedTaskInstanceFields.delete_old_records(ti.task_id, ti.dag_id)
+                    if not RenderedTaskInstanceFields.has_templated_fields(ti, session):
+                        session.add(RenderedTaskInstanceFields(ti))
 
 Review comment:
   What should happen when we clear TI status

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services