You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/02/01 23:45:16 UTC
[GitHub] rdblue commented on a change in pull request #87: Add
LocationProvider to determine data file locations.
rdblue commented on a change in pull request #87: Add LocationProvider to determine data file locations.
URL: https://github.com/apache/incubator-iceberg/pull/87#discussion_r253234562
##########
File path: spark/src/main/java/com/netflix/iceberg/spark/source/Writer.java
##########
@@ -96,7 +87,8 @@
@Override
public DataWriterFactory<InternalRow> createWriterFactory() {
- return new WriterFactory(table.spec(), format, dataLocation(), table.properties(), fileIo);
+ return new WriterFactory(
+ table.spec(), format, table.locationProvider(), table.properties(), fileIo);
Review comment:
Serialization?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org