You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Andrea Pescetti <pe...@apache.org> on 2012/06/24 16:30:22 UTC
[RELEASE] [3.4.1] Bug 119229 as blocker (download new versions of
extensions)
This bug only affects the build infrastructure, but I propose it as a
blocker for 3.4.1:
https://issues.apache.org/ooo/show_bug.cgi?id=119229
The build process downloads some extensions, including dictionaries.
Unless the build process starts completely clean (and it didn't as of
the 3.4.0 builds), the build would reuse an older, cached, version of
the extension even if a newer one was specified in extensions.lst; in
other words, editing extensions.lst in order to specify to download
version 1.1 of the Italian dictionary instead of version 1.0 would have
unpredictable effects (one would get version 1.1 in a completely clean
build, version 1.0 if he had already built OpenOffice before the change).
The fix is obviously low-risk, so it probably makes sense to backport it
to 3.4.1. See http://s.apache.org/xkuN for context.
Regards,
Andrea.
Re: [RELEASE] [3.4.1] Bug 119229 as blocker (download new versions
of extensions)
Posted by Andre Fischer <af...@a-w-f.de>.
On 28.06.2012 13:29, Andrea Pescetti wrote:
> On 25/06/2012 Jürgen Schmidt wrote:
>> On 6/24/12 4:30 PM, Andrea Pescetti wrote:
>>> This bug only affects the build infrastructure, but I propose it as a
>>> blocker for 3.4.1:
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119229
>>> Unless the build process starts completely clean (and it didn't as of
>>> the 3.4.0 builds), the build would reuse an older, cached, version of
>>> the extension even if a newer one was specified in extensions.lst
>> I can see a benefit for the source release but not very critical. But
>> don't see the demand for our binary release because we can easy check it.
>
> If the build system has been improved and binary builds provided by the
> project are now fine (in OpenOffice 3.4.0 the build system did not
> cleanup previously downloaded extensions, resulting in the Spanish and
> Italian dictionaries not being updated), it's of course OK for me. What
> I'd like to ensure is just that this doesn't happen with the current
> build process, otherwise it might be better to backport the fix.
Like Juergen, I see this as nice to have but not as critical.
>
>> If somebody volunteers to include, built and test it for 3.4.1 then I
>> would support it.
>> Any volunteer?
>
> I might have a look, but only in the pre-build phase (which should be
> enough: you don't need to fully build the office to check what version
> of the extension is downloaded).
Well, you might want to make sure that the extension is properly
recognized and added when the install set is created (at the very end of
the build process.) But I agree that checking that configure and
bootstrap work are probably enough.
-Andre
Re: [RELEASE] [3.4.1] Bug 119229 as blocker (download new versions
of extensions)
Posted by Andrea Pescetti <pe...@apache.org>.
On 25/06/2012 Jürgen Schmidt wrote:
> On 6/24/12 4:30 PM, Andrea Pescetti wrote:
>> This bug only affects the build infrastructure, but I propose it as a
>> blocker for 3.4.1:
>> https://issues.apache.org/ooo/show_bug.cgi?id=119229
>> Unless the build process starts completely clean (and it didn't as of
>> the 3.4.0 builds), the build would reuse an older, cached, version of
>> the extension even if a newer one was specified in extensions.lst
> I can see a benefit for the source release but not very critical. But
> don't see the demand for our binary release because we can easy check it.
If the build system has been improved and binary builds provided by the
project are now fine (in OpenOffice 3.4.0 the build system did not
cleanup previously downloaded extensions, resulting in the Spanish and
Italian dictionaries not being updated), it's of course OK for me. What
I'd like to ensure is just that this doesn't happen with the current
build process, otherwise it might be better to backport the fix.
> If somebody volunteers to include, built and test it for 3.4.1 then I
> would support it.
> Any volunteer?
I might have a look, but only in the pre-build phase (which should be
enough: you don't need to fully build the office to check what version
of the extension is downloaded).
Regards,
Andrea.
Re: [RELEASE] [3.4.1] Bug 119229 as blocker (download new versions
of extensions)
Posted by Jürgen Schmidt <jo...@googlemail.com>.
On 6/24/12 4:30 PM, Andrea Pescetti wrote:
> This bug only affects the build infrastructure, but I propose it as a
> blocker for 3.4.1:
> https://issues.apache.org/ooo/show_bug.cgi?id=119229
>
> The build process downloads some extensions, including dictionaries.
> Unless the build process starts completely clean (and it didn't as of
> the 3.4.0 builds), the build would reuse an older, cached, version of
> the extension even if a newer one was specified in extensions.lst; in
> other words, editing extensions.lst in order to specify to download
> version 1.1 of the Italian dictionary instead of version 1.0 would have
> unpredictable effects (one would get version 1.1 in a completely clean
> build, version 1.0 if he had already built OpenOffice before the change).
>
> The fix is obviously low-risk, so it probably makes sense to backport it
> to 3.4.1. See http://s.apache.org/xkuN for context.
I can see a benefit for the source release but not very critical. But
don't see the demand for our binary release because we can easy check it.
If somebody volunteers to include, built and test it for 3.4.1 then I
would support it.
Any volunteer?
Juergen