You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/05/27 11:44:35 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1084: MINIFICPP-1569 Readd test running in Windows builds
lordgamez opened a new pull request #1084:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1084
Jira ticket: https://issues.apache.org/jira/browse/MINIFICPP-1569
---------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1084: MINIFICPP-1569 Readd test running in Windows builds
Posted by GitBox <gi...@apache.org>.
lordgamez commented on pull request #1084:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1084#issuecomment-849632659
> please update Windows.md with the new option
Updated in cc51b33dea40fdda2c389cb6e132d86cbd97637b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1084: MINIFICPP-1569 Readd test running in Windows builds
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #1084:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1084#issuecomment-849609622
please update Windows.md with the new option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1084: MINIFICPP-1569 Readd test running in Windows builds
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1084:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1084#discussion_r640581989
##########
File path: win_build_vs.bat
##########
@@ -21,6 +21,7 @@ if [%1]==[] goto usage
set builddir=%1
set skiptests=OFF
+set runtests=OFF
Review comment:
Updated in 1502d43415f55f955f3e10c1f50967e6dc98050c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1084: MINIFICPP-1569 Readd test running in Windows builds
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1084:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1084: MINIFICPP-1569 Readd test running in Windows builds
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1084:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1084#discussion_r640558014
##########
File path: win_build_vs.bat
##########
@@ -21,6 +21,7 @@ if [%1]==[] goto usage
set builddir=%1
set skiptests=OFF
+set runtests=OFF
Review comment:
I would keep the default of running tests. This script is used locally as well, not just for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org