You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/11 10:31:38 UTC
[GitHub] [airflow] ashb commented on a change in pull request #5298:
[WIP][AIRFLOW-4534] Remove redundant list around dict comprehensions
ashb commented on a change in pull request #5298: [WIP][AIRFLOW-4534] Remove redundant list around dict comprehensions
URL: https://github.com/apache/airflow/pull/5298#discussion_r292387139
##########
File path: airflow/jobs/backfill_job.py
##########
@@ -185,7 +185,7 @@ def _update_counters(self, ti_status):
:param ti_status: the internal status of the backfill job tasks
:type ti_status: BackfillJob._DagRunTaskStatus
"""
- for key, ti in list(ti_status.running.items()):
+ for key, ti in ti_status.running.items():
Review comment:
This one at least is still needed:
```
airflow/jobs/backfill_job.py line 188 in _update_counters
for key, ti in ti_status.running.items():
RuntimeError: dictionary changed size during iteration
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services