[GitHub] [cassandra] rtib commented on pull request #1362: [CASSANDRA-16378] Expose all client options via system_views.clients and nodetool clientstats

[GitBox <gi...@apache.org>]

rtib commented on pull request #1362:
URL: https://github.com/apache/cassandra/pull/1362#issuecomment-1000304437


   I've added a ClientsTableTest which is querying the virtual table and asserting some values.
   
   First I've added assertion for driver_name and driver_version columns, which values should be contained in the client_options, however, this depends on the behaviour of StartupMessage rather than Clients itself, thus testing this is violating the SUT boundary. I don't know if it is a good idea to keep those ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org