You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/17 21:33:46 UTC
[GitHub] [airflow] kaxil opened a new pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
kaxil opened a new pull request #18338:
URL: https://github.com/apache/airflow/pull/18338
When ``wait_for_downstream`` is set on a task, mini scheduler doesn't respect it
and goes ahead to schedule unrunnable task instances.
This PR fixes it by including all direct downstream tasks so that ``wait_for_downstream`` check works correctly.
Resolves https://github.com/apache/airflow/pull/18310#discussion_r711101901
Closes: #18229
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #18338:
URL: https://github.com/apache/airflow/pull/18338#discussion_r711561784
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -740,13 +740,17 @@ def test_mini_scheduler_works_with_wait_for_upstream(self, caplog, dag_maker):
job1 = LocalTaskJob(task_instance=ti2_a, ignore_ti_state=True, executor=SequentialExecutor())
job1.task_runner = StandardTaskRunner(job1)
job1.run()
- ti2_a.refresh_from_db()
+ session.flush()
+ ti2_a.refresh_from_db(session)
+ ti2_b.refresh_from_db(session)
assert ti2_a.state == State.SUCCESS
assert ti2_b.state == State.NONE
Review comment:
Indeed, there a bit of an anit-pattern
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -740,13 +740,17 @@ def test_mini_scheduler_works_with_wait_for_upstream(self, caplog, dag_maker):
job1 = LocalTaskJob(task_instance=ti2_a, ignore_ti_state=True, executor=SequentialExecutor())
job1.task_runner = StandardTaskRunner(job1)
job1.run()
- ti2_a.refresh_from_db()
+ session.flush()
+ ti2_a.refresh_from_db(session)
+ ti2_b.refresh_from_db(session)
assert ti2_a.state == State.SUCCESS
assert ti2_b.state == State.NONE
Review comment:
Indeed, they are a bit of an anit-pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18338:
URL: https://github.com/apache/airflow/pull/18338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18338:
URL: https://github.com/apache/airflow/pull/18338#discussion_r711379668
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -740,13 +740,17 @@ def test_mini_scheduler_works_with_wait_for_upstream(self, caplog, dag_maker):
job1 = LocalTaskJob(task_instance=ti2_a, ignore_ti_state=True, executor=SequentialExecutor())
job1.task_runner = StandardTaskRunner(job1)
job1.run()
- ti2_a.refresh_from_db()
+ session.flush()
+ ti2_a.refresh_from_db(session)
+ ti2_b.refresh_from_db(session)
assert ti2_a.state == State.SUCCESS
assert ti2_b.state == State.NONE
Review comment:
I hate these refresh functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #18338:
URL: https://github.com/apache/airflow/pull/18338#discussion_r711363399
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -740,13 +740,17 @@ def test_mini_scheduler_works_with_wait_for_upstream(self, caplog, dag_maker):
job1 = LocalTaskJob(task_instance=ti2_a, ignore_ti_state=True, executor=SequentialExecutor())
job1.task_runner = StandardTaskRunner(job1)
job1.run()
- ti2_a.refresh_from_db()
+ session.flush()
+ ti2_a.refresh_from_db(session)
+ ti2_b.refresh_from_db(session)
assert ti2_a.state == State.SUCCESS
assert ti2_b.state == State.NONE
Review comment:
This was showing outdated info as we didn't run `ti2_b.refresh_from_db(session)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kosteev commented on pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
kosteev commented on pull request #18338:
URL: https://github.com/apache/airflow/pull/18338#issuecomment-922234170
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #18338:
URL: https://github.com/apache/airflow/pull/18338#discussion_r711363399
##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -740,13 +740,17 @@ def test_mini_scheduler_works_with_wait_for_upstream(self, caplog, dag_maker):
job1 = LocalTaskJob(task_instance=ti2_a, ignore_ti_state=True, executor=SequentialExecutor())
job1.task_runner = StandardTaskRunner(job1)
job1.run()
- ti2_a.refresh_from_db()
+ session.flush()
+ ti2_a.refresh_from_db(session)
+ ti2_b.refresh_from_db(session)
assert ti2_a.state == State.SUCCESS
assert ti2_b.state == State.NONE
Review comment:
This was showing outdated info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #18338:
URL: https://github.com/apache/airflow/pull/18338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18338: Fix mini scheduler not respecting ``wait_for_downstream`` dep
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18338:
URL: https://github.com/apache/airflow/pull/18338#issuecomment-922095133
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org